Upgrading from 1.3.3 to 1.3.9r172 (SQL bug)

[StudioZ]

Sorry Been a while…
While having a day off, I was trying to upgrade on a test copy of my iroutier.com site (version 1.3.3) to the lastest snapshot (1.5 r115)
I ran in some SQL disparencies. To validate the bug, I installed a fresh 1.3.3 version an tried to run an upgrade to 1.5 r115.
Here's the SQL errors I got:

19__1.3.3_to_1.3.4.sql OK

19__1.3.4_to_1.3.5.sql
ERROR: Duplicate column name 'acat_overwrite' -> ALTER TABLE `phpwcms_articlecat` ADD `acat_overwrite` VARCHAR( 255 ) NOT NULL;
ERROR: Duplicate column name 'acontent_paginate_page' -> ALTER TABLE `phpwcms_articlecontent` ADD `acontent_paginate_page` INT( 5 ) UNSIGNED NOT NULL;
ERROR: Duplicate column name 'acontent_paginate_title' -> ALTER TABLE `phpwcms_articlecontent` ADD `acontent_paginate_title` VARCHAR( 255 ) NOT NULL;
ALTER TABLE `phpwcms_articlecontent` ADD INDEX ( `acontent_paginate_page` );

20__1.3.5_to_1.3.5.1.sql
ERROR: Table '133r115.phpwcms_categories' doesn't exist -> ALTER TABLE `phpwcms_categories` ADD `cat_pid` INT( 11 ) NOT NULL AFTER `cat_type`;
ERROR: Table '133r115.phpwcms_categories' doesn't exist -> ALTER TABLE `phpwcms_categories` ADD INDEX ( `cat_pid` );
ERROR: Table 'phpwcms_log' already exists -> CREATE TABLE `phpwcms_log` (
`log_id` int(11) NOT NULL auto_increment,
`log_type` varchar(255) NOT NULL,
`log_timestamp` timestamp NOT NULL,
`log_message` text NOT NULL,
`log_ip` varchar(50) NOT NULL,
`log_userid` varchar(255) NOT NULL,
PRIMARY KEY (`log_id`)
) TYPE=MyISAM;
ALTER TABLE `phpwcms_guestbook` CHANGE `guestbook_created` `guestbook_created` INT(11) NOT NULL;
ALTER TABLE `phpwcms_userlog` CHANGE `logged_change` `logged_change` INT(11) DEFAULT '0' NOT NULL;
ALTER TABLE `phpwcms_userlog` CHANGE `logged_start` `logged_start` INT(11) DEFAULT '0' NOT NULL;
ALTER TABLE `phpwcms_articlecat` CHANGE `acat_alias` `acat_alias` VARCHAR(255) NOT NULL;
ALTER TABLE `phpwcms_articlecat` DROP INDEX `acat_alias`, ADD INDEX `acat_alias` (`acat_alias`);
ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ALTER TABLE `phpwcms_file` DROP INDEX `f_shortinfo`, ADD INDEX `f_shortinfo` (`f' at line 2 -> ALTER TABLE `phpwcms_file` DROP INDEX `f_name`, ADD INDEX `f_name` (`f_name`)
ALTER TABLE `phpwcms_file` DROP INDEX `f_shortinfo`, ADD INDEX `f_shortinfo` (`f_shortinfo`);

21__1.3.5_to_1.5.sql
ALTER TABLE `phpwcms_articlecat` ADD `acat_archive` INT( 1 ) NOT NULL DEFAULT '0';
ALTER TABLE `phpwcms_articlecat` ADD INDEX ( `acat_archive` );
ALTER TABLE `phpwcms_article` ADD `article_archive_status` INT( 1 ) NOT NULL DEFAULT '1';
ALTER TABLE `phpwcms_article` ADD INDEX ( `article_archive_status` );
ALTER TABLE `phpwcms_articlecontent` ADD `acontent_category` VARCHAR( 255 ) NOT NULL;
ALTER TABLE `phpwcms_file` CHANGE `f_cat` `f_cat` VARCHAR( 255 ) NOT NULL;
ALTER TABLE `phpwcms_file` CHANGE `f_changed` `f_changed` INT NOT NULL DEFAULT '0';
ALTER TABLE `phpwcms_file` CHANGE `f_created` `f_created` INT NOT NULL DEFAULT '0';
ALTER TABLE `phpwcms_file` DROP `f_log`;
ALTER TABLE `phpwcms_file` CHANGE `f_longinfo` `f_longinfo` TEXT NOT NULL;
ALTER TABLE `phpwcms_file` ADD `f_copyright` VARCHAR( 255 ) NOT NULL;
ALTER TABLE `phpwcms_file` ADD `f_tags` VARCHAR( 255 ) NOT NULL;
ALTER TABLE `phpwcms_file` CHANGE `f_size` `f_size` INT( 15 ) UNSIGNED NOT NULL DEFAULT '0';
ERROR: Table '133r115.phpwcms_calendar' doesn't exist -> ALTER TABLE `phpwcms_calendar` ADD `calendar_lang` VARCHAR( 255 ) NOT NULL;
ERROR: Table '133r115.phpwcms_calendar' doesn't exist -> ALTER TABLE `phpwcms_calendar` ADD INDEX ( `calendar_lang` );
ALTER TABLE `phpwcms_file` ADD `f_granted` INT NOT NULL DEFAULT '0';
ALTER TABLE `phpwcms_file` ADD INDEX ( `f_granted` );
ALTER TABLE `phpwcms_articlecontent` ADD `acontent_granted` INT NOT NULL DEFAULT '0';
ALTER TABLE `phpwcms_articlecontent` ADD INDEX ( `acontent_granted` );
ERROR: Table '133r115.phpwcms_calendar' doesn't exist -> ALTER TABLE `phpwcms_calendar` ADD `calendar_teaser` TEXT NOT NULL AFTER `calendar_where`;

Hope this may help Oliver to pinpoint/fix the SQL for upcoming versions so we can easily catch up on his work…

Cheers,

Yves

[StudioZ]

No one else faced this problem?
Anyone?

[jscholtysik]

Hi Yves,


I had exactly the same problem. I tried the update on my webserver and on my local machine, both times the same results...

I restored my backup and have now the "old" 1.3.5 again on my webserver...


Joachim

[StudioZ]

Thank you for confirming Joachim

Hi Yves,
I had exactly the same problem. I tried the update on my webserver and on my local machine, both times the same results...
I restored my backup and have now the "old" 1.3.5 again on my webserver...
Joachim

[juergen]

why not adding:

Code: Select all

- 
-- Tabellenstruktur für Tabelle `phpwcms_calendar`
-- 

CREATE TABLE `phpwcms_calendar` (
  `calendar_id` int(11) NOT NULL auto_increment,
  `calendar_created` datetime NOT NULL default '0000-00-00 00:00:00',
  `calendar_changed` datetime NOT NULL default '0000-00-00 00:00:00',
  `calendar_status` int(1) NOT NULL default '0',
  `calendar_start` datetime NOT NULL default '0000-00-00 00:00:00',
  `calendar_end` datetime NOT NULL default '0000-00-00 00:00:00',
  `calendar_allday` int(1) NOT NULL default '0',
  `calendar_range` int(1) NOT NULL default '0',
  `calendar_range_start` date NOT NULL default '0000-00-00',
  `calendar_range_end` date NOT NULL default '0000-00-00',
  `calendar_title` varchar(255) NOT NULL default '',
  `calendar_where` varchar(255) NOT NULL default '',
  `calendar_text` mediumtext NOT NULL,
  `calendar_tag` varchar(255) NOT NULL default '',
  `calendar_object` longtext NOT NULL,
  `calendar_refid` int(11) NOT NULL default '0',
  PRIMARY KEY  (`calendar_id`),
  KEY `calendar_status` (`calendar_status`),
  KEY `calendar_start` (`calendar_start`),
  KEY `calendar_end` (`calendar_end`),
  KEY `calendar_tag` (`calendar_tag`),
  KEY `calendar_refid` (`calendar_refid`),
  KEY `calendar_range` (`calendar_range`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1 AUTO_INCREMENT=1 ;

and redoing the setup ?

Didn't try, but if this calendar is right things should go well

[StudioZ]

DF6IH, thanks for your suggestion…
Although… I did tried this at first but there is more than this…
There is the also the "phpwcms_categories' doesn't exist" to fix and some altering to fix in the source to make sure everyone can easily upgrade to the latest revision(s)

Cheers,

Yves

[Oliver Georgi]

r115 is no official release and was not recommend for public update even you know what you do! A default install does not fail.

And r115 is not supported!

Oliver

[Oliver Georgi]

And hey - where is the problem to make an own upgrade sql that solves your problem based on the error messages in combination with default dump and give it back...

Oliver

[update]

r115 is no official release and was not recommend for public update

We will become very unhappy when trying to start any kind of support for these interim solutions. As far as I can understand this whole procedure with SVNs it's a sneaking into Master's Kitchen only and nothing else. Until no official "go" is uttered we have to handle all these aforementioned "problems"...
So OG is right while asking

....make an own upgrade sql that solves your problem based on the error messages in combination with default dump and give it back...

This for sure will be of some help
Nevertheless I personally would really like to be able to "get the whole picture"... of what's going on in this kitchen

[Cipolla]

Oliver,

r115 is no official release and was not recommend for public update even you know what you do! A default install does not fail.

First of all, i can understand your point of view, but Yves posting was for my understanding only a hint for debugging. It wasn´t a "Hey Oliver, help me to get things work, there are many problems"

On the other hand i don´t know if it is a good idea to discuss bugs or unclear things relating the "kitchen preview" in a posting placed here and there in this forum. Ok, now one should keep those things to himself, but maybe a "BETA AREA" in this forum could be a good idea to talk about previews or unsupported updates.

I believe there are many newbees here which are very insecured because of those treads regarding phpWcms bugs in previews.

Just wanted to throw in my two cents.

[StudioZ]

And hey - where is the problem to make an own upgrade sql
that solves your problem based on the error messages in combination with default dump and give it back...
Oliver

Oliver by no means I wanted to upset you and/or critic your work
In fact, what I seen in r115 is very promising and I was willing to beta test it live.
Maybe you should relax a bit Oliver You seem to be a bit on the edge
Just like Cipolla understood it… I just wanted to bring to your attention these SQL things that
will need to be debug at some point before you go too far with other SQL upgrades.
These fixes could be done by myself or anyone else here who can find the time for it.
Right now I am really not sure when I'll be able to spend time on this like I did before
when fixing the SQL upgrades to go from 1.2.6 to 1.3.3 but… hmmm… we'll have to see…

Take it easy Oliver

Yves

[pepe]

Hi Yves,

i think, the best is, to see those new revisions as experimental versions. And so i did.
After 4 trials to make an update... and failed 4 times... i decided to make only fresh installations with it.

And that's, what works very well.

So i can find out, what's new, what's working ond where Oliver is juggeling.
It's a little bit like "looking over my neighbors fence"

And a second aspect of all those installations, i can see, that something is going on with phpwcms ...

[StudioZ]

SOLVED, at :
http://forum.phpwcms.org/viewtopic.php?f=1&t=17163

Cheers,

Yves