A brasserie website

360fusion · Post by **360fusion** » Thu 29. Mar 2007, 11:59

Hi,

I have just completed this site http://www.thebrasserieyarm.co.uk

any comments welcome.

Thanks
Ben

beat · Post by **beat** » Thu 29. Mar 2007, 17:59

Hi Ben

I like the design of the site, simple and clean.

But you have to make a few changes. First of all the site dosen't validate. For example you have a in your ul.

then your #address is not opening the wrap or whatever you use on the index. So the address is popping out over the main container.

360fusion · Post by **360fusion** » Thu 29. Mar 2007, 20:02

Hi Beat,

Thanks for the feed back and heads up on the validation issue. I fixed the issue. What browser are you using to get errors on the Address? I have now set the div tag to a fixed width, hope this has fixed the issue.

This is the first site i've done with version 1.3. I notice the stylesheet doesn't validate or can't be found. Is this because the frontend.css is now imported now?

Does anyone have any comments on this?

Ben

DeXXus · Post by **DeXXus** » Thu 29. Mar 2007, 20:51

360fusion wrote:Hi Beat,

Thanks for the feed back and heads up on the validation issue. I fixed the issue. What browser are you using to get errors on the Address? I have now set the div tag to a fixed width, hope this has fixed the issue.

This is the first site i've done with version 1.3. I notice the stylesheet doesn't validate or can't be found. Is this because the frontend.css is now imported now?

Does anyone have any comments on this?

Ben

Hi Ben!

W3C CSS Validator Results for http://www.thebrasserieyarm.co.uk/
Warnings (2)
URI : http://www.thebrasserieyarm.co.uk/
25 Do not put style rules inside HTML comments as they may be removed by user agent
30 Do not put style rules inside HTML comments as they may be removed by user agent

Ditch the HTML comments surrounding style rules and import statement:

Code: Select all

<style media="all" type="text/css">

<!--
body {
margin: 0;
padding-top: 0;
padding-bottom: 0;
padding-left: 0;
padding-right: 0;}
//-->

</style>
<style type="text/css">

<!--
@import url("template/inc_css/frontend.css");
//-->

DeXXus · Post by **DeXXus** » Thu 29. Mar 2007, 20:58

WDG HTML Validation Results

Document Checked

* URL: http://www.thebrasserieyarm.co.uk/
* Last modified: Tue, 20 Mar 2007 08:55:18 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/home.phtml
* Last modified: Tue, 20 Mar 2007 08:55:18 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Menu.phtml
* Last modified: Tue, 20 Mar 2007 08:44:45 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Whats ... erie.phtml
* Last modified: Tue, 20 Mar 2007 13:16:20 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/virtual_tour.phtml
* Last modified: Mon, 19 Mar 2007 23:38:32 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/about_us.phtml
* Last modified: Tue, 20 Mar 2007 11:57:53 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/contact_us.phtml
* Last modified: Sat, 24 Mar 2007 12:11:31 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Early_Bird.phtml
* Last modified: Tue, 20 Mar 2007 13:12:44 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Lunch.phtml
* Last modified: Mon, 19 Mar 2007 23:11:58 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/A_La_Carte.phtml
* Last modified: Tue, 20 Mar 2007 13:07:27 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Sunday_Lunch.phtml
* Last modified: Tue, 20 Mar 2007 13:11:32 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Newsletter.phtml
* Last modified: Mon, 19 Mar 2007 13:54:03 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Find_Us.phtml
* Last modified: Tue, 20 Mar 2007 09:34:05 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Gallery.phtml
* Last modified: Mon, 19 Mar 2007 15:38:49 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/privacy.phtml
* Last modified: Mon, 12 Mar 2007 15:37:31 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/access.phtml
* Last modified: Mon, 19 Mar 2007 23:29:47 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/site_map.phtml
* Last modified: Mon, 12 Mar 2007 15:34:10 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/1.0.0.1.0.0.phtml
* Last modified: Tue, 20 Mar 2007 08:44:45 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Drinks_Menu.phtml
* Last modified: Tue, 20 Mar 2007 11:58:16 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/4.0.0.1.0.0.phtml
* Last modified: Tue, 20 Mar 2007 11:57:53 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Virtual_Tour.phtml
* Last modified: Mon, 19 Mar 2007 23:38:32 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Contact_Us.phtml
* Last modified: Sat, 24 Mar 2007 12:11:31 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/googlemap.htm
* Last modified: Tue, 20 Mar 2007 09:36:03 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Strict

Errors and Warnings

* Line 32, character 20:

<body leftmargin="0" topmargin="0" marginwidth="0" marginh ...
^

Error: there is no attribute leftmargin for this element (in this HTML version)
* Line 32, character 34:

... ody leftmargin="0" topmargin="0" marginwidth="0" marginheigh ...
^

Error: there is no attribute topmargin for this element (in this HTML version)
* Line 32, character 50:

... 0" topmargin="0" marginwidth="0" marginheight="0" dir="ltr" ...
^

Error: there is no attribute marginwidth for this element (in this HTML version)
* Line 32, character 67:

... marginwidth="0" marginheight="0" dir="ltr" onload="load()" o ...
^

Error: there is no attribute marginheight for this element (in this HTML version)

Document Checked

* URL: http://www.thebrasserieyarm.co.uk/8.0.0.1.0.0.phtml
* Last modified: Mon, 12 Mar 2007 15:34:10 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Privacy.phtml
* Last modified: Mon, 12 Mar 2007 15:37:31 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/Access.phtml
* Last modified: Mon, 19 Mar 2007 23:29:47 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!
Document Checked

* URL: http://www.thebrasserieyarm.co.uk/About_Us.phtml
* Last modified: Tue, 20 Mar 2007 11:57:53 GMT
* Character encoding: UTF-8
* Level of HTML: XHTML 1.0 Transitional

Congratulations, no errors!

Checked 27 pages.

Nordlicht · Post by **Nordlicht** » Thu 29. Mar 2007, 22:14

How can you check the hole site in one turn?
I'd like to do this with my site www_bau-facts_de

DeXXus · Post by **DeXXus** » Thu 29. Mar 2007, 22:23

Nordlicht wrote:How can you check the hole site in one turn?
I'd like to do this with my site www_bau-facts_de

FireFox extension:
http://www.totalvalidator.com/tool/extension.html

360fusion · Post by **360fusion** » Fri 30. Mar 2007, 11:19

Hi DeXXus,

this is the old code phpwcms 1.2.8 rendered. This validates fine on my sites.

Code: Select all

  <style type="text/css" media="all">
  /* <![CDATA[ */
    body {
      margin: 0;
      padding-top: 0;
      padding-bottom: 0;
      padding-left: 0;
      padding-right: 0;

    }
  /* ]]> */
  </style>
  <style type="text/css">
  /* <![CDATA[ */
    @import url("phpwcms_template/inc_css/frontend.css");
  /* ]]> */
  </style>

what file do i need to edit to Ditch the HTML comments surrounding style rules and import statement.

Is this something that i will need to change with all phpwcms 1.3 sites or is it something i have done wrong?

Thanks
Ben

360fusion · Post by **360fusion** » Fri 30. Mar 2007, 11:33

I disabled the margins in pagelayout instead of just unticking them, this has removed the html tag for body but i still have one error and the stylesheet still can't be found by the jigsaw.w3 validator.

Is it because the CDATA code is missing? Should the code read?

Code: Select all

<style type="text/css">
/*<![CDATA[*/

....lots of styles here...

/*]]>*/
</style>

Ben

pico · Post by **pico** » Fri 30. Mar 2007, 12:25

Hi
CSE-Validator say's:

In XHTML documents, style and script content must not be in a comment because it technically means that the browser will see it as a comment and not as actual style or script content (though browsers are currently forgiving about this). However, not using comments makes your document less compatible with pre HTML 3.2 browsers (but most browsers now in use are HTML 3.2+ compatible). For maximum compatibility, consider putting the style information in an external style sheet. The next best option for XHTML documents is to not put the style information in a comment because this is technically not what you want even though it may work with today's browsers.

so I think you can safely remove the Comment Tags from the System !? or switch to /* <![DATA[ */ construct

they are defined in include/inc: lib/default.inc.php ~Line 122 ff

for me it works best with Browsers without any Comment or Data Construct

btw

Code: Select all

table width="150" border="0" cellspacing="0" cellpadding="0">

  <tr>
    <td>

<ul>
    <li><a href="Early_Bird.phtml">Early Bird</a></li>
    <li><a href="Lunch.phtml">Lunch</a></li>
    <li><a href="A_La_Carte.phtml">A La Carte</a></li>
    <li><a href="Sunday_Lunch.phtml">Sunday Lunch</a></li>

<br />
    <li><a href="Newsletter.phtml">Newsletter</a></li>
    <li><a href="Find_Us.phtml">Find Us</a></li>
    <li><a href="Whats_On_At_The_Brasserie.phtml">What's On</a></li>
    <li><a href="Gallery.phtml">Gallery</a></li>
  </ul>

</td>

  </tr>
</table>

the is not allowed in ul/li - if you need a Linebreak you have to split it into two ul/li Sections and the Table wrap around makes no sense to me !?

Code: Select all

<ul>
    <li><a href="Early_Bird.phtml">Early Bird</a></li>
    <li><a href="Lunch.phtml">Lunch</a></li>
    <li><a href="A_La_Carte.phtml">A La Carte</a></li>
    <li><a href="Sunday_Lunch.phtml">Sunday Lunch</a></li>
</ul>
<ul>
    <li><a href="Newsletter.phtml">Newsletter</a></li>
    <li><a href="Find_Us.phtml">Find Us</a></li>
    <li><a href="Whats_On_At_The_Brasserie.phtml">What's On</a></li>
    <li><a href="Gallery.phtml">Gallery</a></li>
</ul>

DeXXus · Post by **DeXXus** » Fri 30. Mar 2007, 15:21

pico wrote:the is not allowed in ul/li - if you need a Linebreak you have to split it into two ul/li Sections

If he spacing between seems to be slightly different than desired... you can -also- try the "obvious"...
(place the -inside- the <li> pair before that divide):

Code: Select all

<ul> 
    <li><a href="Early_Bird.phtml">Early Bird</a></li> 
    <li><a href="Lunch.phtml">Lunch</a></li> 
    <li><a href="A_La_Carte.phtml">A La Carte</a></li> 
    <li><a href="Sunday_Lunch.phtml">Sunday Lunch</a><br /><br /></li> 
    <li><a href="Newsletter.phtml">Newsletter</a></li> 
    <li><a href="Find_Us.phtml">Find Us</a></li> 
    <li><a href="Whats_On_At_The_Brasserie.phtml">What's On</a></li> 
    <li><a href="Gallery.phtml">Gallery</a></li> 
</ul>

360fusion · Post by **360fusion** » Fri 30. Mar 2007, 17:13

Hi,

thanks for your feedback and advice, I have changed the unordered list and put the inside the <li> tags and also uncommented the define('SCRIPT_CDATA_ start and end in include/inc: lib/default.inc.php

Everyhtng seems to validate through jigsaw now.

Thanks again
Ben

beat · Post by **beat** » Sat 31. Mar 2007, 14:17

ok the display problem in FF, Safari and so on ist not solved. I copied your markup and the css and changed it slightly. see my pm.
The site will then work.

I really suggest you not to use any tables in your layout if not absolutly needed. I left them in my fix, but I strongly recommend you to remove them.

When coding XHTML allways keep the proper semantic in mind, it will save you a lot of problems.