bug in rewrite url

Post by **Oliver Georgi** » Fri 23. Apr 2004, 12:23

Hi Florian,

the file ending is absolute uninteresting (when you use rewrite On) - you can write *.florian there too (or funny: *.aspx)

By default shtml is the default ending for Server Side Include files. Apache has no problem with it.

The rewrite function grabs the request and sends it to the right file -> index.php. But the rewrite function in phpwcms will never change the link index.php to index.shtml. So there is no need to set "DirectoryIndex index.html index.php index.shtml" too in .htaccess or your httpd.conf.

Links with flags are not rewritten - but this too isn't problematic - as I could test. The Link isn't rewritten in that fact - and working. Rewriting URL should make it easier for search engines - for all other people there is no real advantage.

After testing I have found that the ending *.shtml is the best solution for most accounts. There is no need to change any other filename on the web account like if you use *.html as ending. That made a lot of problems when you want to have normal html files installed beside phpwcms (or the WYSIWYG editors have lot of problems with it). The rewrite code in RC3 should run out of the box - as I could test - on most systems. And this was something I could never use before I have changed it - neither on Win nor *NIX. Now often it is enough to rename _.htaccess to .htaccess. It seems to work too in subdirs without any change.

And if I check the source code of inokoo.de I can see this:
<a href="/?kontakt" target="_self"> How should this be rewritten? It has to be <a href="index.php?kontakt" target="_self"> - then it will...

Regards
Oliver

frold · Post by **frold** » Fri 23. Apr 2004, 13:10

very good explanation of how the rewrite function work... It make some things more clear for me...

Thx Oliver...

Florian · Post by **Florian** » Fri 23. Apr 2004, 14:02

Hello Oliver,

thanks for your reply. Of course I know what the mod_rewrite function does.
But first let me tell you that I'm such kind of damn stupid thats unbelivable. I PATCHED SEVERAL ACCOUNTS RUNNING ON PHPWCMS WITH THE RC-1. MAN! How could that happen? Maybe it's cause because if sleepd much to less or the wind blows from wrong direction or so...
I'm very sorry for stealing your time for the reply you made.

Now I have to fix some truckloads of accounts... Shit shit shit.

Bye,
Florian

Post by **Oliver Georgi** » Fri 23. Apr 2004, 14:12

Hm, sorry Florian.

Oliver

Florian · Post by **Florian** » Fri 23. Apr 2004, 23:43

Hi there,

now I'm finished up with "patching" all system back to the right patch. Everything is working fine. Thanks to all who were involved with the new release

.

Oliver, can you add the following replacement Tag to the next release, because it's very usefull (http://www.phpwcms.de/forum/viewtopic.php?t=993)

Good night - good fight,
Florian

frold · Post by **frold** » Sat 24. Apr 2004, 00:24

Florian wrote: Good night - good fight,
Florian

As I understand it it was you that where fighting...