[SOLVED] Shop Module item detail "Show All" url error

Get help with installation and running official modules for phpwcms here. Please do not post bug reports or feature requests here.
Post Reply
nebenaube
Posts: 139
Joined: Fri 23. Nov 2007, 20:39
Location: Redlands, CA
Contact:

[SOLVED] Shop Module item detail "Show All" url error

Post by nebenaube » Sat 14. Feb 2009, 00:33

Hmmm... how to describe this. I have searched the forum and haven't found a reference to this issue. Perhaps it was discussed in German.
I find it hard to believe no one else has encounter the defect.

In my shop I have two products, both listed in all products and in a given sub-category. When navigating to the product detail the "Show All" link did not return to the respective product list. This was because the url still included the shop_detail variable, i.e. /index.php?Shop&shop_detail=1&shop_cat=3_4

After some digging in /include/inc_module/shop_module/frontend.render.php . I found around line 505 the following code:

Code: Select all

if( count($shop_cat) ) {
	
		$x = 0;
		$entry = array();
		
		if(!$shop_detail_id) {  <---- APPARENT ERROR HERE
			unset($GLOBALS['_getVar']['shop_detail']);
		}
		
		$shop_prod_detail = 'index.php'.returnGlobalGET_QueryString('htmlentities');
		
So I changed it thusly by removing the "not operator":

Code: Select all

if($shop_detail_id) {
	unset($GLOBALS['_getVar']['shop_detail']);
}
Which produced the desired navigation result, i.e. a url containing /index.php?Shop&shop_cat=3_4

I don't see anywhere else in the code where this change has produced an ill effect.

off to google now to post the issue...

Post Reply